Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make transformation_service_endpoint configuration optional #4880

Merged

Conversation

xaniasd
Copy link
Contributor

@xaniasd xaniasd commented Dec 27, 2024

What this PR does / why we need it:

Prevents the Go feature server from panicking when transformation_service_endpoint configuration is not defined in feature_store.yaml.

Which issue(s) this PR fixes:

N/A

@xaniasd xaniasd requested a review from a team as a code owner December 27, 2024 14:26
@xaniasd xaniasd changed the title Make transformation_service_endpoint configuration optional fix: Make transformation_service_endpoint configuration optional Dec 27, 2024
@xaniasd xaniasd force-pushed the optional-tf-service-endpoint branch from f0d6939 to dabdebc Compare January 2, 2025 16:11
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Dimitris Stafylarakis <xanias@gmail.com>
…nit tests

Signed-off-by: Dimitris Stafylarakis <xanias@gmail.com>
@xaniasd xaniasd force-pushed the optional-tf-service-endpoint branch from b74ae33 to 22ed81f Compare January 3, 2025 15:02
@franciscojavierarceo franciscojavierarceo merged commit c62377b into feast-dev:master Jan 3, 2025
21 checks passed
@xaniasd xaniasd deleted the optional-tf-service-endpoint branch January 3, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants